Merge serialize addon into master #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist join instead and some code clean up
add SerializeAddon
mode leading to serialize return wrong sequence
…ed(), _lineStart() functions
…api from xterm.d.ts
…ns/xterm-addon-serialize and add README.md
Add foreground/background color support for SerializeAddon
|
Please merge #2687 to fix the pipeline failure |
fix: api test fail due to IBufferCell api changes
Tyriar
commented
Feb 4, 2020
Replace with fetching cell (0,0) and using that as the initial null cell. We can reconsider adding this back if it's needed
This reverts commit 0b6a5b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should merge after #2369 gets merged