Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebLinkProvider to handle wrapped lines properly. #3718

Merged
merged 3 commits into from Mar 31, 2022
Merged

Fix WebLinkProvider to handle wrapped lines properly. #3718

merged 3 commits into from Mar 31, 2022

Conversation

LuckyGeck
Copy link
Contributor

@LuckyGeck LuckyGeck commented Mar 30, 2022 •
edited

For wrapped lines we also need to adjust start position of the link, same as it's already being done for the end position.

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2022

@LuckyGeck can you create/link an issue that this PR is trying to fix?

@LuckyGeck
Copy link
Contributor Author

Sure, filed an issue #3721 for this, please take a look!

@Tyriar Tyriar added this to the 4.19.0 milestone Mar 31, 2022
Tyriar
Tyriar approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks 👍

@Tyriar Tyriar enabled auto-merge March 31, 2022 16:15
@Tyriar Tyriar merged commit 23afd53 into xtermjs:master Mar 31, 2022
@LuckyGeck LuckyGeck deleted the fixweblink branch March 31, 2022 19:06
@afska afska mentioned this pull request Nov 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LuckyGeck @Tyriar