Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong weblink highlighting in wrapped terminal lines #3721

Closed
LuckyGeck opened this issue Mar 30, 2022 · 0 comments · Fixed by #4288
Closed

Wrong weblink highlighting in wrapped terminal lines #3721

LuckyGeck opened this issue Mar 30, 2022 · 0 comments · Fixed by #4288
Labels
area/addon/web-links type/bug Something is misbehaving
Milestone
5.1.0

Comments

@LuckyGeck
Copy link
Contributor

Web links in long lines are incorrectly highlighted when the link is on the second line or further.

bugreport

Details

  • Browser and browser version: Chrome
  • OS version: MacOS 12.3
  • xterm.js version: 4.18.0

Steps to reproduce

  1. Paste http://google.com multiple times into a terminal until it wraps onto a second line
  2. Hover over the last instance of the uri.
@LuckyGeck LuckyGeck mentioned this issue Mar 30, 2022
Merged
@Tyriar Tyriar added this to the 4.19.0 milestone Mar 31, 2022
@Tyriar Tyriar added type/bug Something is misbehaving area/addon/web-links labels Mar 31, 2022
@Tyriar Tyriar removed this from the 4.19.0 milestone Jun 26, 2022
@jerch jerch mentioned this issue Dec 8, 2022
Merged
4 tasks
@Tyriar Tyriar added this to the 5.1.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/web-links type/bug Something is misbehaving
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix weblinks jerch/xterm.js
2 participants
@LuckyGeck @Tyriar