Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support semi-colons in OSC 8 hyperlink URIs #5003

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Support semi-colons in OSC 8 hyperlink URIs #5003

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b40e58b
Fix https://github.com/xtermjs/xterm.js/issues/4944 by only splitting…
josiahhudson Mar 15, 2024
487278a
Merge branch 'master' into master
Tyriar Apr 21, 2024
0e77f83
Use indexOf(';') approach
Tyriar Apr 21, 2024
d77b41e
Add tests to cover OSC 8 hyperlinks
Tyriar Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/InputHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,7 +2972,7 @@ export class InputHandler extends Disposable implements IInputHandler {
* feedback. Use `OSC 8 ; ; BEL` to finish the current hyperlink.
*/
public setHyperlink(data: string): boolean {
const args = data.split(';');
const args = data.match(/^([^;]*);(.*)$/)?.slice(1) ?? [];
Tyriar marked this conversation as resolved.
Show resolved Hide resolved
if (args.length < 2) {
return false;
}
Expand Down