Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give API access to valid link elements #627

Merged
merged 4 commits into from
Apr 5, 2017
Merged

Give API access to valid link elements #627

merged 4 commits into from
Apr 5, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 4, 2017

Fixes #591

Opps, didn't create a PR for this one apparently.

@Tyriar Tyriar added this to the 2.5.0 milestone Apr 4, 2017
@Tyriar Tyriar self-assigned this Apr 4, 2017
@Tyriar Tyriar requested a review from parisk April 4, 2017 16:43
@Tyriar Tyriar modified the milestones: 2.6.0, 2.5.0 Apr 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 68.809% when pulling 584ec68 on Tyriar:591_element_on_validation into 0c5b5cc on sourcelair:master.

parisk
parisk approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit df13469 into xtermjs:master Apr 5, 2017
@Tyriar Tyriar deleted the 591_element_on_validation branch April 5, 2017 18:34
@Tyriar Tyriar modified the milestones: 2.5.0, 2.6.0 Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk