Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force failing mocha tests to return a exit code of 1 #652

Merged
merged 1 commit into from May 4, 2017
Merged

Force failing mocha tests to return a exit code of 1 #652

merged 1 commit into from May 4, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 3, 2017

Fixes #651

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.708% when pulling 03d26e3 on Tyriar:651_fix_travis_fail into 64d3c08 on sourcelair:master.

@Tyriar Tyriar assigned Tyriar and unassigned parisk May 3, 2017
@Tyriar Tyriar requested a review from parisk May 3, 2017 18:28
parisk
parisk reviewed May 4, 2017
View reviewed changes
gulpfile.js
@@ -83,6 +83,7 @@ gulp.task('instrument-test', function () {
gulp.task('mocha', ['instrument-test'], function () {
return gulp.src([`${outDir}/*test.js`, `${outDir}/**/*test.js`], {read: false})
.pipe(mocha())
.once('error', () => process.exit(1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got only two questions and this is good to go:

  1. Does this stop the test suit completely if an error occurs at some time? (I would consider this blocking)
  2. Does this prevent instanbul from writing coverage reports when tests fail? (Non-blocking)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I assume so yes
  2. Yes

Don't we want it to fail completely? Partial coverage reports aren't very useful imo.

@Tyriar Tyriar merged commit daad8d9 into xtermjs:master May 4, 2017
@Tyriar Tyriar deleted the 651_fix_travis_fail branch May 4, 2017 15:35
@parisk parisk modified the milestone: 2.6.0 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk