Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with parser state when using vtop #672

Merged
merged 1 commit into from May 27, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 25, 2017

Fixes #662


See the comment in code for an explanation, I couldn't figure out the root cause but after Parser.parse finished, the state of it would reset. Interestingly, this works:

var state = this.parser.parse(data);
this.parser.setState(state);

Where this does not:

this.parser.setState(this.parser.parse(data));

@Tyriar Tyriar added this to the 2.7.0 milestone May 25, 2017
@Tyriar Tyriar requested a review from parisk May 25, 2017 16:40
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 69.002% when pulling 2c3d98a on Tyriar:662_parser_state_hack into 35b32b7 on sourcelair:master.

@Tyriar Tyriar self-assigned this May 25, 2017
@Tyriar Tyriar merged commit 42724c7 into xtermjs:master May 27, 2017
@Tyriar Tyriar deleted the 662_parser_state_hack branch May 27, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants