Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single element for the middle of the selection #691

Merged
merged 3 commits into from
Jun 13, 2017
Merged

Use a single element for the middle of the selection #691

merged 3 commits into from
Jun 13, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 9, 2017

This reduces the number of DOM nodes used for the selection dramatically.

screen shot 2017-06-09 at 4 36 28 pm

@Tyriar
Use a single element for the middle of the selection
9246d52 
This reduces the number of DOM nodes used for the selection dramatically.
@Tyriar Tyriar added this to the 2.8.0 milestone Jun 9, 2017
@Tyriar Tyriar self-assigned this Jun 9, 2017
@Tyriar Tyriar requested a review from parisk June 9, 2017 23:37
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.482% when pulling 9246d52 on Tyriar:mid_selection_single_element into a889fef on sourcelair:master.

@Tyriar Tyriar mentioned this pull request Jun 9, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.482% when pulling a5ced5d on Tyriar:mid_selection_single_element into c33814a on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.49% when pulling 201e3e4 on Tyriar:mid_selection_single_element into 55f51ad on sourcelair:master.

@Tyriar Tyriar merged commit 7612180 into xtermjs:master Jun 13, 2017
@Tyriar Tyriar deleted the mid_selection_single_element branch June 13, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk