Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render selection on top of rows #719

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Render selection on top of rows #719

merged 3 commits into from
Jun 21, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 19, 2017

Fixes #718

Before:

image

After:

image

@Tyriar Tyriar added this to the 2.8.0 milestone Jun 19, 2017
@Tyriar Tyriar self-assigned this Jun 19, 2017
@Tyriar Tyriar requested a review from parisk June 19, 2017 18:20
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.688% when pulling 57921e3 on Tyriar:718_selection_on_top into 75b74ac on sourcelair:master.

@Tyriar Tyriar mentioned this pull request Jun 19, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.688% when pulling 6dbc476 on Tyriar:718_selection_on_top into 75b74ac on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.688% when pulling ba54f25 on Tyriar:718_selection_on_top into af268f4 on sourcelair:master.

@Tyriar Tyriar merged commit 4c3aa97 into xtermjs:master Jun 21, 2017
@Tyriar Tyriar deleted the 718_selection_on_top branch June 21, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk