Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu in firefox #722

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Fix context menu in firefox #722

merged 1 commit into from
Jun 21, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 20, 2017

Fixes #721

@Tyriar Tyriar added this to the 2.8.0 milestone Jun 20, 2017
@Tyriar Tyriar self-assigned this Jun 20, 2017
@Tyriar Tyriar requested a review from parisk June 20, 2017 17:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.688% when pulling 32f1782 on Tyriar:721_firefox_contextmenu into 75b74ac on sourcelair:master.

parisk
parisk approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Tyriar Tyriar merged commit af268f4 into xtermjs:master Jun 21, 2017
@Tyriar Tyriar deleted the 721_firefox_contextmenu branch June 21, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk