Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Terminal.hasSelection return false when no selection #725

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Have Terminal.hasSelection return false when no selection #725

merged 2 commits into from
Jun 21, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 20, 2017

Fixes #724

@Tyriar Tyriar added this to the 2.8.0 milestone Jun 20, 2017
@Tyriar Tyriar self-assigned this Jun 20, 2017
@Tyriar Tyriar requested a review from parisk June 20, 2017 17:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.793% when pulling 7b46940 on Tyriar:724_fix_hasSelection into 75b74ac on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.62% when pulling f1252ab on Tyriar:724_fix_hasSelection into 11d6ca2 on sourcelair:master.

@Tyriar Tyriar merged commit 1c84881 into xtermjs:master Jun 21, 2017
@Tyriar Tyriar deleted the 724_fix_hasSelection branch June 21, 2017 15:38
@Tyriar Tyriar mentioned this pull request Jun 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk