Fix turning from alt screen to normal screen and vice versa. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parisk can you look? |
parisk
reviewed
Jun 26, 2017
| @@ -1440,8 +1441,8 @@ export class InputHandler implements IInputHandler { | |||
| * Save cursor (ANSI.SYS). | |||
| */ | |||
| public saveCursor(params: number[]): void { | |||
| this._terminal.savedX = this._terminal.buffer.x; | |||
| this._terminal.savedY = this._terminal.buffer.y; | |||
| this._terminal.buffers.active.x = this._terminal.buffer.x; | |||
There was a problem hiding this comment.
this._terminal.buffers.active is the same with this._terminal.buffer.
I am not sure yet though if the savedX and savedY cursor positions have to be stored in the buffer or universally in the terminal.
Any thoughts?
There was a problem hiding this comment.
Ok I will look.
parisk
approved these changes
Jun 26, 2017
|
Thanks @AndrienkoAleksandr! This seems to be working. Can you take a look at https://github.com/sourcelair/xterm.js/pull/728/files#r123939766 though, as I will need to change this piece of code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix turning from alt screen to normal screen and vice versa.
Fix #229.
Target branch: buffer-set