Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop selection when the active buffer changes #733

Merged
merged 4 commits into from
Jun 30, 2017
Merged

Drop selection when the active buffer changes #733

merged 4 commits into from
Jun 30, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 27, 2017

Fixes #732

@Tyriar Tyriar added this to the 2.8.0 milestone Jun 27, 2017
@Tyriar Tyriar self-assigned this Jun 27, 2017
@Tyriar Tyriar requested a review from parisk June 27, 2017 17:13
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.665% when pulling 645a592 on Tyriar:732_drop_selection_on_alt into f95bc64 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.665% when pulling 3961dd5 on Tyriar:732_drop_selection_on_alt into 471e332 on sourcelair:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.665% when pulling f071531 on Tyriar:732_drop_selection_on_alt into 618768c on sourcelair:master.

parisk
parisk approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.665% when pulling b8163cf on Tyriar:732_drop_selection_on_alt into a9f8290 on sourcelair:master.

@Tyriar Tyriar merged commit 4eac766 into xtermjs:master Jun 30, 2017
@Tyriar Tyriar deleted the 732_drop_selection_on_alt branch June 30, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk