Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure scroll bar is refreshed after erase all in display #761

Merged
merged 4 commits into from Jul 13, 2017
Merged

Ensure scroll bar is refreshed after erase all in display #761

merged 4 commits into from Jul 13, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 5, 2017

Fixes #760

@Tyriar Tyriar added this to the 2.9.0 milestone Jul 5, 2017
@Tyriar Tyriar self-assigned this Jul 5, 2017
@Tyriar Tyriar requested a review from parisk July 5, 2017 20:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 69.418% when pulling 7f5e72d on Tyriar:760_erase_in_display_scroll_bar into 479fb0e on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 9, 2017 •
edited

Coverage Status

Coverage increased (+0.006%) to 69.436% when pulling e4770de on Tyriar:760_erase_in_display_scroll_bar into 99061c6 on sourcelair:master.

parisk
parisk approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage increased (+0.006%) to 69.529% when pulling 9a358b2 on Tyriar:760_erase_in_display_scroll_bar into 25fc01c on sourcelair:master.

@Tyriar Tyriar merged commit 2ebc926 into xtermjs:master Jul 13, 2017
@Tyriar Tyriar deleted the 760_erase_in_display_scroll_bar branch July 13, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tyriar @coveralls @parisk