Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search.exclude setting for vscode workspace #772

Merged
merged 2 commits into from Jul 11, 2017
Merged

Add search.exclude setting for vscode workspace #772

merged 2 commits into from Jul 11, 2017

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Jul 10, 2017

Adds some simple vscode search.exclude settings for the workspace

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2017

@parisk this would be very useful to add for users developing in VS Code.

Before:

image

After:

image

@Tyriar Tyriar self-assigned this Jul 10, 2017
@Tyriar Tyriar requested review from parisk and Tyriar July 10, 2017 22:26
@coveralls
Copy link

coveralls commented Jul 10, 2017 •
edited

Coverage Status

Coverage remained the same at 69.444% when pulling 29545a9 on mjbvz:add-search-exclude-for-vscode into e849e3f on sourcelair:master.

@coveralls
Copy link

coveralls commented Jul 11, 2017 •
edited

Coverage Status

Coverage remained the same at 69.444% when pulling 4df8d3a on mjbvz:add-search-exclude-for-vscode into 8fab079 on sourcelair:master.

parisk
parisk approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@parisk parisk merged commit 86c5aa0 into xtermjs:master Jul 11, 2017
@Tyriar Tyriar added this to the 2.9.0 milestone Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjbvz @Tyriar @coveralls @parisk