-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix save and restore cursor behavior #822
Conversation
This broke in xtermjs#717. Fixes xtermjs#818
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch.
LGTM 🚀
Ok, merge it, but seems that's not a fix, this is alternative of real solution... |
I am working on some tests on this topic, https://github.com/AndrienkoAleksandr/xterm.js/blob/fixFullResetTerminal/src/test/test.js#L1025 |
@AndrienkoAleksandr are you sure we want to save/restore the cursor when switching to/from the alt buffer? I assume it was originally commented out for a reason and I'm not sure xterm does this https://github.com/joejulian/xterm/blob/defc6dd5684a12dc8e56cb6973ef973e7a32caa3/misc.c#L4172 |
@AndrienkoAleksandr clarification on what's wrong with this would be good too, is it just the save/restore on buffer change? |
This broke in #717.
Fixes #818