Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full height gist creation #68

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add full height gist creation #68

merged 1 commit into from
Jul 15, 2022

Conversation

xthexder
Copy link
Owner

A possible solution to Issue #67

I'll want to test this on a few more browsers / machines before I merge it, since I don't want extra scrollbars appearing if the height is off.

@jpluimers Give this change a try and see if it's to your liking

image

@xthexder xthexder merged commit 860ee63 into master Jul 15, 2022
@xthexder xthexder deleted the gist_height branch July 15, 2022 19:43
@jpluimers
Copy link

This is much better. I don't care much about double scrollbars, so locally I have modified height: calc(100vh - 500px) !important; and made the 500px bit smaller.

You might want to add a comment on that line to mention the 500px reserves 500 pixels so double scrollbars are avoided.

Thanks for this quick solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants