Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #53

Merged
merged 6 commits into from
Jan 11, 2019
Merged

v1.0.0 #53

merged 6 commits into from
Jan 11, 2019

Conversation

reganlawton
Copy link
Collaborator

React v16 major update

jphautin and others added 5 commits July 20, 2018 17:14
add possibility to use the input in an input-group
- Added key prop to KeyboardedInput render children
- Updated/ cleaned examples
@MarkEhr
Copy link

MarkEhr commented Jan 10, 2019

Hi, why isn't this merged? Is there any breaking change?

@reganlawton
Copy link
Collaborator Author

reganlawton commented Jan 10, 2019 via email

@MarkEhr
Copy link

MarkEhr commented Jan 10, 2019

There's a warning that can be easily fixed bumping the peerDependencies inside the package.json
They could be changed to:

"peerDependencies": {     
    "react": "~0.14.8 || ^15.0.0 || ^16.0.0",
    "react-dom": "~0.14.8 || ^15.0.0 || ^16.0.0"
  },

If we don't want to drop support for old react versions.

@reganlawton
Copy link
Collaborator Author

I’m pretty sure the React 16 was there for a reason original but I’ve just checked the code it would work with v15 still.

It’s almost 9pm in Australia I’ll make the change in the morning and get this committed first thing when I hit the office, after giving it a once over.

@reganlawton reganlawton merged commit 7f5aff6 into master Jan 11, 2019
@reganlawton
Copy link
Collaborator Author

@MarkEhr thats merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants