Skip to content

Commit

Permalink
Page is a number
Browse files Browse the repository at this point in the history
  • Loading branch information
xuanxu committed Aug 11, 2023
1 parent 83d9267 commit cbf32f7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/theoj/retraction_notice.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def metadata
volume: journal.current_volume,
issue: journal.current_issue,
year: journal.current_year,
page: "#{retracted_paper.page}R",
page: retracted_paper.page,
journal_alias: journal.alias,
software_review_url: retracted_paper.paper_review,
archive_doi: retracted_paper.software_archive.to_s.gsub("https://doi.org/", ""),
Expand Down
8 changes: 4 additions & 4 deletions spec/lib/retraction_notice_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
volume: @journal.current_volume,
issue: @journal.current_issue,
year: @journal.current_year,
page: "45678R",
page: "45678",
journal_alias: "test_journal",
software_review_url: "https://github.com/openjournals/test_journal/issues/5567",
archive_doi: "10.AAAA/zenodo.33",
Expand Down Expand Up @@ -114,19 +114,19 @@
volume: @journal.current_volume,
issue: @journal.current_issue,
year: @journal.current_year,
page: "45678R"
page: "45678"
}
}.to_json
),
citation_string: "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678R, https://doi.org/paper-doiR"
citation_string: "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678, https://doi.org/paper-doiR"
}

expect(@retraction_notice.deposit_payload).to eq(expected_deposit_payload)
end
end

it "should create a valid citation string" do
expect(@retraction_notice.citation_string).to eq "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678R, https://doi.org/paper-doiR"
expect(@retraction_notice.citation_string).to eq "Editorial Board, (#{@journal.current_year}). Retraction notice for: Test paper. Test Journal, #{@journal.current_volume}(#{@journal.current_issue}), 45678, https://doi.org/paper-doiR"
end

describe "#deposit!" do
Expand Down

0 comments on commit cbf32f7

Please sign in to comment.