Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/xdev: fix exit code when error #811

Merged
merged 1 commit into from
May 12, 2020
Merged

cmd/xdev: fix exit code when error #811

merged 1 commit into from
May 12, 2020

Conversation

icexin
Copy link
Contributor

@icexin icexin commented May 12, 2020

Description

Make xdev return a non-zero exit code when error is encountered.

fxsjy
fxsjy approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@fxsjy fxsjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icexin icexin merged commit 38fcf20 into xuperchain:master May 12, 2020
@icexin icexin deleted the xdev_exit branch May 12, 2020 03:17
icexin added a commit to icexin/xuperunion that referenced this pull request May 12, 2020
@icexin
cmd/xdev: fix exit code when error (xuperchain#811)
c9f8de2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxsjy fxsjy fxsjy approved these changes

@qizheng09 qizheng09 qizheng09 approved these changes

@yucaowang yucaowang Awaiting requested review from yucaowang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icexin @fxsjy @qizheng09