Update expected generated outputs for github.com/xuri/xgen/pull/36 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
alexandre-normand
force-pushed
the
fix-expected-outputs-to-include-extension-support
branch
from
aafffc9
to
f8ab5a6
Compare
|
@xuri : This should also get merged to have xgen tests passing again after xuri/xgen#36. |
|
LGTM, thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With github.com/xuri/xgen/pull/36, the generated output should be stable with a sort on members being done. This updates the expected outputs so that the new tests looking at the content can pass.