Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Some units have too few pre-treatment observations. Try to remove them." #1

Closed
ahearn15 opened this issue Jun 3, 2020 · 5 comments

Comments

@ahearn15
Copy link

ahearn15 commented Jun 3, 2020

I noticed with the gsynth package, you automatically remove observations that do not reach the min.t0 threshold:

gsynth:

Some treated units has too few pre-treatment periods; they are removed automatically.

fect:

Error in fect.cv(Y = Y, X = X, D = D, I = I, II = II, T.on = T.on, T.off = T.off, : Some units have too few pre-treatment observations. Try to remove them.

Would it be possible for that feature to be added to fect?

@xuyiqing
Copy link
Owner

xuyiqing commented Jun 3, 2020 via email

@ahearn15
Copy link
Author

ahearn15 commented Jun 3, 2020

Great, thank you! Keep up the awesome work.

@ahearn15 ahearn15 closed this as completed Jun 3, 2020
@liqizheng0328
Copy link

when using your amazing package, I found that it reported the error: Some units have too few pre-treatment observations. Try to remove them. But owing to my date which lacks enough pre-treatment observations, I still want to have a try on scm despite it does not perform well even badly. So what can I do to remove this error or limit.( which may guarantee the credibility of results)
I would appreciate some feedback on it. THANK YOU!!!

@xuyiqing
Copy link
Owner

xuyiqing commented Oct 11, 2022 via email

@liqizheng0328
Copy link

Hi, You can set min.T0 to a small number.

On Tue, Oct 11, 2022 at 9:41 AM liqizheng0328 @.> wrote: when using your amazing package, I found that it reported the error: Some units have too few pre-treatment observations. Try to remove them. But owing to my date which lacks enough pre-treatment observations, I still want to have a try on scm despite it does not perform well even badly. So what can I do to remove this error or limit.( which may guarantee the credibility of results) I would appreciate some feedback on it. THANK YOU!!! — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2PKGCFQEVVGMM4VKST2R3WCWKD5ANCNFSM4NRIMHIQ . You are receiving this because you commented.Message ID: @.>
-- Yiqing Xu Assistant Professor Department of Political Science Stanford University https://yiqingxu.org/

Error in gsynth.default(formula = NULL, data = data, Y = Yname, D = Dname, :
Some treated units has too few pre-treatment periods. Please set a larger value for min.T0 to remove them. Equal or greater than 6 is recommended.

THANK FOR YOUR REPLY!
It seems that this function does not allow me to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants