Add remote_addr field to Request #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiya! This project still kicking? |
Closed
Closed
|
This should now be in the main development branch. I pulled in @sigaloid's version that uses the |
|
Glad to see you are back! It is a fine solution. <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to retrieve the IP addresses from the remote hosts that connect to the server, so added a simple implementation for getting the underlying
stream.peer_addr()to the Request struct.One thing I considered is if this should be done at the HTTP-level but since there is no guarantee that the remote host's IP is included in the headers I did this instead. Also debated whether or not it should use SocketStream instead of just String, but this is the simplest solution for now.
Love the project's philosophy, btw! <3