cloudflare-go: Exit gracefully when role is unimplemented #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @claucece, in case you are planning to make conflicting changes to this :) |
The cloudflare-go server currently does not implement the "dc" test case. The expected behavior is for the endpoint to exit with code 64. This PR refactors cloudflare-go to allow for this behavior.
cjpatton
force-pushed
the
cjpatton/cloudflare-go-exit
branch
from
484c057
to
a140a70
Compare
|
@chris-wood to continue the discussion on the question posed here, we could just have the endpoints return 64 for any inputs that they don't recognize/that are invalid. That would save them the trouble of keeping track of what is and isn't valid for the runner (for example, we could possibly have a role in the future called |
chris-wood
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue discussed in #36.
The cloudflare-go server currently does not implement the "dc" test
case. The expected behavior is for the endpoint to exit with code 64.
This PR refactors cloudflare-go to allow for this behavior.