HELM38: Value to download glowroot jar from url #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GridexX <arsene582@gmail.com>
GridexX
force-pushed
the
feat/add-glowroot-url-values
branch
from
c333868
to
1f2246e
Compare
gsautner
approved these changes
Aug 25, 2023
charts/xwiki/values.yaml
Outdated
| @@ -314,7 +314,9 @@ properties: | |||
| # "key": "value" | |||
|
|
|||
| glowroot: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
Let's keep disabled by default. Since it's an additional load on the process, user can choose to enable only when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR I added two options
versionandurlto allow changing the glowroot JAR urlThe version is used to change the
GLOWROOT_VERSIONvariable and is afterwards used in the URL.