Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELM-58 Improve security (ServiceAccount, securityContext) and harmonize indent #29

Conversation

dominikkaminski
Copy link
Contributor

Hey 👋

This PR does:

  • ServiceAccount creation by default. This is recommend to comply with IT-Grundschutz and pass compliance rule
  • Harmonize indent of all list (indent 2)
  • Remove empty initContainers: block in rendered template when volumePermissions.enabled is false.
  • Fix typo customKeyRef which fixes rendering exception with default values.

@gsautner gsautner self-assigned this Jan 23, 2024
@gsautner gsautner changed the title Improve security (ServiceAccount, securityContext) and harmonize indent HELM-58 Improve security (ServiceAccount, securityContext) and harmonize indent Jan 23, 2024
@gsautner gsautner merged commit 60b2c18 into xwiki-contrib:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants