Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIssues with inserting links to wiki pages #73
Comments
This comment has been minimized.
This comment has been minimized.
|
For the first problem (click on links in view mode) I can see the problem, I'll work on it. For the second problem, you need to give more details as I can't reproduce on my local instance. There must be something special with the cloud instance. Was there any JavaScript exception logged in the console on the cloud? Do you have a link where I can reproduce? |
This comment has been minimized.
This comment has been minimized.
|
The second issue I reproduced only on Cloud, not on local instances. I don't get anything new when I click the Apply button, the info in the console appears when I edit the Diagram I used https://gabybasic.demo-staging.infra-staging.devxwiki.com/xwiki/bin/view/Main/ |
* Disable the async mode for the resource selector UIX because there are some issues on XWiki 10.11.9 on cloud.
* Make the wiki links clickable in view mode.
* Clear the selection and collapse the tree whenever the Edit Link dialog is opened for a wiki link * Add support for removing the link (by not selecting any node from the tree or by leaving the input empty)
ane-gabriela commentedSep 24, 2019
Tested on XWiki 8.4.5, 11.3.4 and 11.7 and the Internal link can be added on a specific text but after Save & View, nothing happens when the link is clicked. It works for external links.
On Cloud (10.11.9) it seems the Internal link can't be added at all - after selecting to link to a specific page from the picker, nothing happens when clicking the Apply button. The external link works.
Regarding #64