Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with inserting links to wiki pages #73

Closed
ane-gabriela opened this issue Sep 24, 2019 · 2 comments

Comments

@ane-gabriela
Copy link

commented Sep 24, 2019

Tested on XWiki 8.4.5, 11.3.4 and 11.7 and the Internal link can be added on a specific text but after Save & View, nothing happens when the link is clicked. It works for external links.

On Cloud (10.11.9) it seems the Internal link can't be added at all - after selecting to link to a specific page from the picker, nothing happens when clicking the Apply button. The external link works.

Regarding #64

CloudApply

@ane-gabriela ane-gabriela added this to the 1.9 milestone Sep 24, 2019
@mflorea mflorea self-assigned this Oct 1, 2019
@mflorea

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

For the first problem (click on links in view mode) I can see the problem, I'll work on it. For the second problem, you need to give more details as I can't reproduce on my local instance. There must be something special with the cloud instance. Was there any JavaScript exception logged in the console on the cloud? Do you have a link where I can reproduce?

@ane-gabriela

This comment has been minimized.

Copy link
Author

commented Oct 1, 2019

The second issue I reproduced only on Cloud, not on local instances. I don't get anything new when I click the Apply button, the info in the console appears when I edit the Diagram
Save ViewInternalLink

I used https://gabybasic.demo-staging.infra-staging.devxwiki.com/xwiki/bin/view/Main/

mflorea added a commit that referenced this issue Oct 2, 2019
* Disable the async mode for the resource selector UIX because there are some issues on XWiki 10.11.9 on cloud.
mflorea added a commit that referenced this issue Oct 3, 2019
* Make the wiki links clickable in view mode.
mflorea added a commit that referenced this issue Oct 3, 2019
* Clear the selection and collapse the tree whenever the Edit Link dialog is opened for a wiki link
* Add support for removing the link (by not selecting any node from the tree or by leaving the input empty)
@mflorea mflorea closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.