Paths to images inserted into diagrams become invalid at upgrade #11 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanalavinia
commented
Oct 3, 2019
oanalavinia
commented
- removes from the graph and the cached svg the information about draw.io at save action and adds it back only for view mode, export as pdf (when there is no attachment and the svg is used) and also when entering in edit mode
…isas#11 * removes from the graph and the cached svg the information about draw.io at save action and adds it for view mode, export as pdf (when there is no attachment and the svg is used) and also when entering in edit mode
…isas#11 * remove draw.io info from the graph xml directly, without traversing graph cells * for export as svg add draw.io info on the output svg, without saving it
mflorea
approved these changes
Oct 4, 2019
| var newPrefix = 'image=' + "$services.webjars.url('org.xwiki.contrib:draw.io', '')" + '/img'; | ||
| diagramXML = diagramXML.replace(/image=\/img/g, newPrefix); | ||
| return diagramXML; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| }; |
It's usually safer to put a semicolon here.
…isas#11 * shortened regex expresion to be more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.