Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't look good in the pop-up #9

Closed
ane-gabriela opened this Issue Jul 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@ane-gabriela
Copy link

ane-gabriela commented Jul 4, 2018

Steps to reproduce:

  1. Click on Create
  2. Add a title
  3. Select Flash Messages type
  4. Choose Start Date > Now and Groups > XWikiAllGroup
  5. Add in the Message description a large text:

Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.

  1. Click on Save & View
  2. Check the display in the pop-up and in the top bar

Expected results: For the pop-up > The text content must be displayed below the date, on multiple lines and fit into the pop-up margins, without adding any scroll bar.

Actual results: The text appears just next to the date and no style seems to be working - the bold and italic.

Environment: Windows 10, XWiki 10.5 with MySQL 5.7 and Edge 17

flashmessagepopup

@ane-gabriela ane-gabriela added this to the 1.4 milestone Jul 4, 2018

@oanalavinia oanalavinia self-assigned this Nov 2, 2018

oanalavinia added a commit to oanalavinia/application-flashmessages that referenced this issue Nov 12, 2018

oanalavinia added a commit to oanalavinia/application-flashmessages that referenced this issue Nov 12, 2018

UI doesn't look good in the pop-up xwikisas#9
* I replaced the old ConfirmationBox with a bootstrap modal for a better display

oanalavinia added a commit to oanalavinia/application-flashmessages that referenced this issue Nov 16, 2018

UI doesn't look good in the pop-up xwikisas#9
* changed some alignment on the modal view so it can look more like the old popup
* replaced $(window) with window
* added events on bs.modal.hidden instead of waiting a period of time so the modal is closed

oanalavinia added a commit to oanalavinia/application-flashmessages that referenced this issue Nov 23, 2018

UI doesn't look good in the pop-up xwikisas#9
* use .click() instead of activeElement

oanalavinia added a commit to oanalavinia/application-flashmessages that referenced this issue Nov 26, 2018

UI doesn't look good in the pop-up xwikisas#9
* updated some code so it will not use velocity
* small changes to have some boolean values instead of strings

mflorea added a commit that referenced this issue Nov 26, 2018

Merge pull request #24 from oanalavinia/issue#9
UI doesn't look good in the pop-up #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.