Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification bell is not marked differently when Silk Icon Theme is used #59

Closed
evalica opened this issue Jun 28, 2019 · 1 comment
Closed

Comments

@evalica
Copy link

evalica commented Jun 28, 2019

This is an usability issue.

Users can install the (PRO) apps, but might have the "Silk Icon Theme" set instead of the default "Font Awesome Icon Theme".
After installing the app, one user continued to his page, to the Macros selector, without going through the AppBar, or noticing the Notification message. He was not aware there are further steps needed in order to complete the installation of the Pro app.

Currently the 2 default Icon Themes have no consistent behavior.

Expected: "Font Awesome"
FontAwesome

Current: "Silk"
Silk
SilkExpanded

Solutions ideas:

  • (easy) add a visible marker to the bell, that is consistent through IconThemes;
  • (medium) we could auto-open the Notification area to display the license message;
  • (complex) clearly state in the Extension Manager that there are multiple steps to do for an application to be installed. For example:
    ** Step (1/4) - when the user pressed on "Install".
    ** Step (2/4) - when the user pressed on "Continue".
    ** Step (3/4) - if the application is paid, he will need to go to the "Licenses".
    ** Step (4/4) - encourage the user to open the application from the AppBar, or direct him to the Macros Index, highlighting the newly installed extension.

Tested with XWiki 11.5 and Calendar Pro 2.8.4.

acotiuga added a commit that referenced this issue Sep 2, 2020
…sed #59

* wrap the notification bell with a red square, since the icon or icon color chan't be changed
@acotiuga
Copy link
Contributor

acotiuga commented Sep 2, 2020

The best solution is to properly integrate the licensor's notifications into the wiki's notification and use the same feature.
However, in order to address the current issue and to provide a (less nice) solution, a red square is wrapping the notification bell. This is more in line with the current behaviour of colouring the bell with red when Font Awesome is used.
Screenshot from 2020-09-02 16-20-55

@acotiuga acotiuga self-assigned this Sep 2, 2020
@acotiuga acotiuga added this to the 1.16.1 milestone Sep 2, 2020
@acotiuga acotiuga closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants