Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the label responsible for sending emails to the participants. #20 #21

Merged
merged 5 commits into from
Aug 13, 2018

Conversation

CostiChD
Copy link

@CostiChD CostiChD commented Aug 1, 2018

Issue: #20

@CostiChD CostiChD changed the title Improve the label responsible for sending emails to the participants. #20 Improve the label responsible for sending emails to the participants. https://github.com/xwikisas/application-meeting/issues/20 Aug 1, 2018
@CostiChD CostiChD changed the title Improve the label responsible for sending emails to the participants. https://github.com/xwikisas/application-meeting/issues/20 Improve the label responsible for sending emails to the participants. #20 Aug 1, 2018
#end
<span class='buttonwrapper'>
<div class='buttonwrapper'>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to not use the older classes, so .buttonwrapper and .button should be replaced with .btn .btn-primary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all I need to do is just to change these two classes, in this code ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evalica
Copy link

evalica commented Aug 7, 2018

This is how it looks on 10.6
after

@evalica
Copy link

evalica commented Aug 7, 2018

There is a problem when editing inline with the title. It shows:
"$escapetool.xml($title)", see
title_issue

Could you please also fix that?

@CostiChD
Copy link
Author

CostiChD commented Aug 7, 2018

Trying to fix it right now.

@evalica
Copy link

evalica commented Aug 7, 2018

I don't know what are the steps to reproduce the "$escapetool.xml($title)". It appears when the meeting entry was created with an empty title, but I can't remember how I've managed to create it like this. I have entries displayed correctly and this bugged entry, so we'll leave the problem for another issue / PR.

@evalica evalica requested a review from acotiuga August 7, 2018 16:02
@acotiuga acotiuga merged commit 645122a into xwikisas:master Aug 13, 2018
@CostiChD CostiChD deleted the MEETING-20 branch September 13, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants