Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] Missing actions for the "Attachments" macro #153

Closed
oanat opened this issue Jun 29, 2023 · 0 comments · Fixed by #161
Closed

[Regression] Missing actions for the "Attachments" macro #153

oanat opened this issue Jun 29, 2023 · 0 comments · Fixed by #161
Assignees
@oanalavinia
Labels
Macro: Attachments Priority: Major
Milestone
1.10

Comments

@oanat
Copy link

oanat commented Jun 29, 2023

On previous versions (e.g. XWiki 13.10 with Pro Macros v1.6) the {{confluence_attachments/}} macro was consistent with the display on the attachments tab: both the upload button and the actions were displayed: AttachmentsMacro-v1 6
On recent versions the upload (already reported on #132 ) and the actions are missing:
AttachmentsMacro-v1 9 2

On XWiki 14.10.13 with Pro Macros v1.9.2 the upload and actions are present on the attachments tab : AttachmentsTab
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Sep 4, 2023
@oanalavinia
[Regression] Missing actions for the "Attachments" macro xwikisas#153
811dad6 
* add the actions tab
* rewrite some attachments tab js code / velocity macros in order to make them specific to this confluence macro; this is done since the attachments tab is not always opened
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Sep 13, 2023
@oanalavinia
[Regression] Missing actions for the "Attachments" macro xwikisas#153
5561110 
* add the actions tab
* rewrite some attachments tab js code / velocity macros in order to make them specific to this confluence macro; this is done since the attachments tab is not always opened
oanalavinia added a commit that referenced this issue Sep 27, 2023
@oanalavinia
[Regression] Missing actions for the "Attachments" macro #153 (#161)
30b4e62 
* add the actions tab
* rewrite some attachments tab js code / velocity macros in order to make them specific to this confluence macro; this is done since the attachments tab is not always opened
@oanalavinia oanalavinia linked a pull request Sep 27, 2023 that will close this issue
[Regression] Missing actions for the "Attachments" macro #153 #161
Merged
@oanalavinia oanalavinia modified the milestones: 1.9.4, 1.10 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Macro: Attachments Priority: Major
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

[Regression] Missing actions for the "Attachments" macro #153 oanalavinia/xwiki-pro-macros
2 participants
@oanat @oanalavinia