Excessive DB queries in admin

[ParhamG]

It seems like running setup_storage()/verify_db() on every requests in admin dashboard is excessive? It is causing the following two DB queries to run on every requests in admin dashboard:

SHOW TABLES LIKE 'wp_stream'
SHOW TABLES LIKE 'wp_stream_meta'

System Information

• Stream plugin version: 3.5.1
• WordPress version: 5.5.1
• PHP version: 7.4

[kidunot89]

@kasparsd How do you think this should be address this? I don't believe this functionality is vital to the plugin, so simply removing this function and the add_action statement on Line 75 should resolve the issue with no breaks 🤞.

[lkraav]

Yeah, it seems like that function should only run on plugin activation hook?

[kidunot89]

@lkraav I don't think that's necessary since the activation hook is where the database changes are setup and error handling already existed in the case of a database failure.

Also if the check causing the issue fails all it does is print an admin notice telling the user to reinstall the plugin. Seems a little redundant to me as an error handling measure 🤷‍♂️.