Stream does not check database tables exist

[tomjn]

Bug Report

Stream only creates database tables on plugin activation, then never checks they exist.

Expected Behavior

Use Stream in an environment here plugin activation occurs.

Stream sees that the tables don't exist and creates them.

Actual Behavior

Stream does not create the tables because you did not load the plugin by activating it.

Additionally, the reset database tables link in settings does not create the tables if they do not exist

Steps to Reproduce the Problem

1. Install Stream using a method that does not involve plugin activation. E.g. as an MU Plugin
2. Try to use it
3. Be constantly told that the database tables do not exist

System Information

• Stream plugin version:
• WordPress version: 5.8
• PHP version: 7.4
• Browser: Chrome
• Computer operating system: Linux

If making it auto-check isn't possible, providing a way to create the tables would also be great. Right now this is extremely frustrating and regularly causes problems with local environments on multiple projects.

[tomjn]

Working around this I got:

wp_stream_get_instance()->install->check();

Running that code once created the tables

[tomjn]

I made a quick PR that adds them when the DB resets, however, the Install class should check on these situations too:

• wp admin requests
• wp cli requests

[kasparsd]

Thanks for reporting the issue @tomjn!

This appears to be related to this very recent change #1201 which was attempting to fix this issue #1169

What would be the most performant way of ensuring the tables exist if we’re doing that on pretty much every request?

Could we use an option to store the schema revision once the tables are created and then assume that the tables are present while the options is there?

[tomjn]

@kasparsd see my last PR, it only checks on WP Admin/CLI requests, avoiding the issue you linked to

[tomjn]

the reset PR also provides a manual way to fix this

[tomjn]

#1285 and #1286 specifically

[kasparsd]

@tomjn Can we assume this is now fixed with #1286 being merged?

[tomjn]

@kasparsd yes, just need a release with it in and I'll have some very happy people :) Closing

[kasparsd]

Thanks for the confirmation and your contribution! I'll create a release either today or early next week.

[kasparsd]

@tomjn 3.8.1 is out now:

• https://github.com/xwp/stream/releases/tag/3.8.1
• https://plugins.trac.wordpress.org/browser/stream/tags/3.8.1
• https://github.com/xwp/stream-dist (should be soon as the CI is done) which is used for the Packagist.org releases.