Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hooks and functions with improper names #269

Merged
merged 21 commits into from Apr 14, 2014
Merged

Conversation

fjarrett
Copy link
Contributor

Resolves #267

@shadyvb Please review. I need some help deprecating the hooks.

Conflicts:
	connectors/settings.php
	includes/admin.php
	includes/feeds.php
	includes/list-table.php
Conflicts:
includes/admin.php
includes/feeds.php
includes/list-table.php
Conflicts:
	includes/admin.php
	includes/feeds.php
	includes/list-table.php
@lukecarbis
Copy link
Contributor

@fjarrett @kucrut @shadyvb It does trigger a deprecated notice for me. Do you have WP_DEBUG on?

@shadyvb
Copy link
Contributor

shadyvb commented Apr 13, 2014

I'm working on deprecating the last one, 'stream_toggle_filters', will be ready to merge once @lukecarbis finishes, or delegates, his work on deprecating filters.

Scratch that, i didn't know that stream_toggle_filters was actually a filter. So, waiting for @lukecarbis

@lukecarbis
Copy link
Contributor

@shadyvb Thanks for that suggestion - much more elegant. I've deprecated stream_toggle_filters as well, so I think we're ready to merge.

@shadyvb
Copy link
Contributor

shadyvb commented Apr 14, 2014

@fjarrett This is yours to merge.

@lukecarbis
Copy link
Contributor

@shadyvb I appreciate the feedback. I'm happy with what we've put together. Ready to merge if @fjarrett wants to give it a 👍 .

@fjarrett
Copy link
Contributor Author

👍

fjarrett added a commit that referenced this pull request Apr 14, 2014
Deprecate hooks and functions with improper names
@fjarrett fjarrett merged commit ae86cc2 into develop Apr 14, 2014
@fjarrett fjarrett deleted the issue-267 branch April 14, 2014 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate any hooks & functions with improper names
4 participants