Only apply live updates during main query and fix dashboard live updates bug #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $rows.removeClass( 'alternate' ); | ||
|
|
||
| $rows.each( function() { |
There was a problem hiding this comment.
Does this work?
$row.each( function( index ) {
$( this ).addClass( index % 2 ? '' : 'alternate' );
}There was a problem hiding this comment.
@lukecarbis We need to also remove the class from existing rows that may already have it.
There was a problem hiding this comment.
Doesn't that happen on line 71? https://github.com/wp-stream/stream/pull/676/files#diff-959e4b03f08d6986c43c1046113e3de4R72
If not, just do this instead:
$( this ).removeClass( 'alternate' ).addClass( index % 2 ? '' : 'alternate' );There was a problem hiding this comment.
@lukecarbis Oh you are totally right! Nice one. Done in 4b08d8e
fjarrett
added a commit
that referenced
this pull request
Jan 12, 2015
Only apply live updates during main query and fix dashboard live updates bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #675
@shadyvb please review