Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixmodal scrollbar issue and selected/active image outline #160

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fixmodal scrollbar issue and selected/active image outline #160

merged 1 commit into from
Jun 11, 2020

Conversation

ravichdev
Copy link
Contributor

Summary

Fixes #147

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

spacedmonkey
spacedmonkey approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested in linux and macos

@ravichdev ravichdev merged commit 77b85ad into develop Jun 11, 2020
@ravichdev ravichdev deleted the fix/147-scrollbar branch June 11, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll bar on the Unsplash Media Selector is not positioned correctly
2 participants
@ravichdev @spacedmonkey