Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add original unsplash meta for edited attachments #189

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Add original unsplash meta for edited attachments #189

merged 4 commits into from
Jul 10, 2020

Conversation

ravichdev
Copy link
Contributor

@ravichdev ravichdev commented Jul 8, 2020 •
edited by spacedmonkey
Loading

Summary

Fixes #173

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

spacedmonkey
spacedmonkey reviewed Jul 8, 2020
View reviewed changes
php/class-hotlink.php Outdated Show resolved Hide resolved
ravichdev and others added 3 commits July 9, 2020 12:07
@ravichdev
Remove original_url meta
89a6286
@ravichdev
Remove invalid test
aea7cff
@ravichdev @spacedmonkey
Add original_attachment_id meta
95eccf8 
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
spacedmonkey
spacedmonkey approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spacedmonkey spacedmonkey added this to the 1.0.1 milestone Jul 9, 2020
@spacedmonkey spacedmonkey merged commit ebd4cf1 into develop Jul 10, 2020
@spacedmonkey spacedmonkey modified the milestones: 1.0.1, 1.0.0 Jul 10, 2020
@derekherman derekherman deleted the fix/55-attachment-meta branch July 21, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Discovery - WP 5.5 image editing tools may break the Unsplash plugin
2 participants
@ravichdev @spacedmonkey