Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery - WP 5.5 image editing tools may break the Unsplash plugin #173

Closed
bmattb opened this issue Jun 23, 2020 · 0 comments · Fixed by #188, #189 or #202
Closed

Discovery - WP 5.5 image editing tools may break the Unsplash plugin #173

bmattb opened this issue Jun 23, 2020 · 0 comments · Fixed by #188, #189 or #202
Assignees

Comments

@bmattb
Copy link
Contributor

bmattb commented Jun 23, 2020

Feature description

WP 5.5 scheduled for August 2020 will introduce new image editing functions that will possibly break our Unsplash plugin functions.

We will need to determine how these changes will impact the plugin and prioritize the work needed to address this prior to that release.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • issues are created to identify the work required to address impacts from 5.5's update to image editing

Implementation brief

Previously in WP when you edited an image it did not create a new image. Now in 5.5, cropping creates a new attachment and generates the required image sizes (thumb, med, lrg), but does not copy over any of the original metadata (ALT, caption, description etc)

This presents an issue for Unsplash in that we need the auto-generated caption, and we break the identification of the image as an Unsplash image that requires hotlinking

The questions now are:

  1. Does editing (cropping) of the Unpslash image need to retain the hotlink and associated tracking
  2. If so, how do we copy the image meta to the new cropped image
  3. If so, how do we keep the tracking in place (tracking pixel)

Jonny's recco:

  1. When the image is cropped there is a hook that provides us with the new ID and the old ID. We could then add a flag to the new image that allows us (at some point in the future) to identify the unsplash images.
  2. If we agree to ignore the new hotlinked image, we should still duplicate the ALT text (and other meta) to the new image so that there is no loss in this data.

QA testing instructions

Demo

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants