Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cropping in WordPress 5.5. #202

Merged
merged 5 commits into from
Aug 3, 2020
Merged

Fix cropping in WordPress 5.5. #202

merged 5 commits into from
Aug 3, 2020

Conversation

spacedmonkey
Copy link
Contributor

Summary

Fix cropping in WordPress 5.5 - RC1. It was a simple as fixing the return value of the wp_image_file_matches_image_meta filter.

Fixes #173

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@spacedmonkey spacedmonkey added this to the 1.0.1 milestone Aug 3, 2020
ravichdev
ravichdev previously approved these changes Aug 3, 2020
Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have one suggestion on the strpos check to ensure it works if the wp_image_file_matches_image_meta method is invoked somewhere without the protocol.

php/class-hotlink.php Outdated Show resolved Hide resolved
Co-authored-by: Ravi Chandra <ravichandrach1@gmail.com>
@spacedmonkey
Copy link
Contributor Author

Looks good, I have one suggestion on the strpos check to ensure it works if the wp_image_file_matches_image_meta method is invoked somewhere without the protocol.

@ravichdev Can you explain this a little more. Not sure what you mean here? I don't check for the proto anywhere, just the domain.

Copy link
Contributor

@ravichdev ravichdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ravichdev ravichdev merged commit da776ce into develop Aug 3, 2020
@ravichdev ravichdev deleted the fix/cropped-image branch August 3, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery - WP 5.5 image editing tools may break the Unsplash plugin
2 participants