Add foundation for integration tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
reviewed
Dec 14, 2019
| @@ -6,6 +6,7 @@ services: | |||
| image: mysql:5 | |||
| volumes: | |||
| - ./data/mysql:/var/lib/mysql | |||
| - ./tests/phpunit/wptests.sql:/docker-entrypoint-initdb.d/wptests.sql | |||
There was a problem hiding this comment.
The MySQL data for the integration tests usually needs to persist only for the duration of the test so we could use a dedicated MySQL container for the integration tests. This would allow us to define a separate database name, username and password via the environment variables which would also cover this init step.
There was a problem hiding this comment.
We're attempting to have a single wordpress container for development and if we had two mysql services then wordpress would have to depend on both or we need a second wordpress specifically for tests. That's what we're trying to avoid.
There was a problem hiding this comment.
I see what you mean by environment variables, but it's just adding complexity.
kasparsd
reviewed
Dec 14, 2019
|
|
||
| script: | ||
| - npm run lint | ||
| - npm run test:php:coverage | ||
| - npm run docker -- npm run test:php:coverage |
There was a problem hiding this comment.
Need to build a proper image though and upload it to Docker Hub. Building during the testing is painful.
|
The coverage report is not merging correctly and so it never sends to Coveralls. It's the last thing to get this working correctly. I went into debug mode in the build and the output of the merge is: But the correct output locally is: The weird part is that the php files are generating correctly for the clover to be generated from. I can't think of an answer. I'll double back later. |
|
@kasparsd I got it to merge the coverage reports and send to Coveralls correctly 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.