Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post slug field #148

Merged
merged 6 commits into from May 26, 2016

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented May 26, 2016

customize_

Placeholder field updates live as title changes.

Fixes #63

@westonruter westonruter added this to the 0.6 milestone May 26, 2016

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 26, 2016

@westonruter We need to filter the post link so it uses the preview URL if the slug is dirty or we get a 404. I'm looking into it now.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

@valendesigns Is this #42? I was thinking the changing of the slug was going to be a problem, but the full page refreshes continued to work even when the slug was being changed. I wasn't able to see a 404.

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 26, 2016

@westonruter I can make it work without #42.

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 26, 2016

@westonruter So it's not pretty but it does the job.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

@valendesigns what were the steps that you used to reproduce the 404?

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 26, 2016

@westonruter

  1. Turned on permalinks
  2. Edited an existing post from the archive
  3. Attempted to navigate to it which produced an 404
@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

@valendesigns wouldn't it be better to just use preview links across the board? See 97ddef1.

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 26, 2016

if ( $post_status_match || $post_slug_mismatch ) {
$permalink = Edit_Post_Preview::get_preview_post_link( $post );
}
if ( is_customize_preview() ) {

This comment has been minimized.

Copy link
@valendesigns

valendesigns May 26, 2016

Member

We want this on the front-end for Snapshots, as well.

This comment has been minimized.

Copy link
@westonruter

westonruter May 26, 2016

Author Contributor

@valendesigns Humm. Why should it be on the snapshotted frontend as well?

And if so, what would be the best way to detect if it is a frontend snapshot preview?

This comment has been minimized.

Copy link
@valendesigns

valendesigns May 26, 2016

Member

@westonruter We can worry about it later, it's not critical since we haven't setup a way to navigate in the snapshot on the front-end. We'll tackle that later. For now we can just merge and move forward. Thoughts?

@westonruter westonruter merged commit baf6af1 into develop May 26, 2016

2 checks passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 95.814%
Details

@westonruter westonruter deleted the feature/post-slug-field branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.