Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control to manipulate the post parent #233

Merged
merged 28 commits into from Sep 10, 2016

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented Aug 30, 2016

Fixes #65.

Continuation of #189.

  • Address PR feedback from #189.
  • Implement get_pages() support in #241 via #250.
  • Critically \WP_Customize_Posts::get_post_parent_choices() is only returning page posts. We would need to get all posts of all post types for this to work. At the very least this data needs to be loaded via Ajax, but likely what should be done is:
  • Make the Customize Object Selector plugin a hard dependency, and introduce a “hierarchical post dropdown” control either in that plugin or in Customize Posts.
  • Show indentation for pages which wp_dropdown_pages() provides, a deficiency with \WP_Customize_Posts::get_post_parent_choices().
  • Merge xwp/wp-customize-object-selector#16 to add wp_dropdown_pages support to the selector control.
  • Add support for page_attributes_dropdown_pages_args filter (this really only makes sense if using object_selector). This could also be implemented later, just as implementing the page-specific templates (theme_page_templates filter) is not yet done.
  • Add support for syncing the customizer value with the parent frame if opened from edit post screen. This can also be deferred for later, since there are other settings which aren't yet implemented.

Other items postponed for another time:

  • Use object selector component with dropdown pages for Jump to Post? Or load stubs for all pages in WP? (There should also be the first page_for_posts auto-loaded for non-hierarchical posts.) See #146.
  • Implement selective refresh for updating a nav menu that contains a post inside of it? See ea425d4

@westonruter westonruter added this to the 0.8 milestone Aug 30, 2016

@westonruter westonruter merged commit 5ed04eb into develop Sep 10, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.5%) to 94.381%
Details

@westonruter westonruter deleted the feature/post-parent branch Sep 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.