Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow widgets to be edited inline #17

Closed
westonruter opened this issue Sep 25, 2013 · 4 comments
Closed

Allow widgets to be edited inline #17

westonruter opened this issue Sep 25, 2013 · 4 comments
Labels
question

Comments

@westonruter
Copy link
Contributor

Instead of having to look up the widget's control in the customizer, what if the widget's form could be brought in alongside the widget itself in the preview? There could be a Edit button that appears next to a widget when hovering over it, and when clicking it could make the widget form appear.
@shaunandrews
Copy link
Contributor

A quick idea:

inline-edit

Do you think the editor should always show up next to the widget itself? What if the user clicks to edit the widgets from within the customizer sidebar?

@westonruter
Copy link
Contributor Author

@shaunandrews wow. I love it!

Regarding what should happen when the user clicks a widget form in the sidebar, here's a crazy idea: what if clicking the collapsed control in the customizer sidebar would simultaneously cause the preview window to scroll so that the widget is in view, while at the same time the widget form would expand and fly out from the sidebar and land next to the widget showing in the preview?

@shaunandrews
Copy link
Contributor

I guess that makes sense, since we would be scrolling to show the active widget anyways. I'm a little concern that this is a lot of motion to have. I won't really know for sure until I can play with it and get a first-hand feeling for it all.

@westonruter westonruter mentioned this issue Oct 19, 2013
Open
westonruter added a commit that referenced this issue Nov 8, 2013
@westonruter
Squashed 'bin/' changes from 86d46a9..894d120
6a9b2c7 
894d120 Merge pull request #18 from x-team/issue-16
de1db88 Remove wordpress- from url
5581e97 Get latest trunk file from github
9d1d025 Add base phpcs ruleset for plugins
5de1b8e Update .jshintrc to match new in core
ab7b9cd Update .tavis.yml to check against master and latest. This closes #16 and #15
9aa3e33 Merge pull request #17 from jonathanbardo/master
63a11a4 Correct small typo
8e3bab1 Merge pull request #15 from jonathanbardo/master
ed0b379 Update WP version to latest stable release
6956ba1 Merge pull request #13 from jonathanbardo/master
a864385 Update WP_VERSION to 3.7
4cd538f Merge branch 'master' of github.com:x-team/wp-plugin-dev-lib
258cdf9 Fix reference from jshint to phpcs
c9f45eb Add formatting
7d26511 Add git-subtree instructions
9c1e6ea Update svn-push to work with svn repo out of git repo

git-subtree-dir: bin
git-subtree-split: 894d120dd0047c75076df7d37a8d9b81bb15aa41
@shaunandrews shaunandrews mentioned this issue Dec 13, 2013
Closed
@westonruter
Copy link
Contributor Author

Closing this for now. We can revisit later.

fnakstad added a commit to knishiura-lab/wp-widget-customizer that referenced this issue Feb 5, 2014
@fnakstad
Fault xwp#17
f66cffb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@westonruter @shaunandrews