modify param check

xwz123 · Jul 21, 2021 · d8e3ced · d8e3ced
1 parent 360bc71
commit d8e3ced
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/dbmodels/link.go b/dbmodels/link.go
@@ -36,9 +36,9 @@ type CLAOfLink struct {
 }
 
 type OrgRepo struct {
-	Platform string `json:"platform" required:"true"`
-	OrgID    string `json:"org_id" required:"true"`
-	RepoID   string `json:"repo_id" required:"true"`
+	Platform string `json:"platform"`
+	OrgID    string `json:"org_id"`
+	RepoID   string `json:"repo_id"`
 }
 
 func (this OrgRepo) OrgRepoID() string {

diff --git a/models/corporation-manager.go b/models/corporation-manager.go
@@ -4,20 +4,19 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/huaweicloud/golangsdk"
 	"github.com/opensourceways/app-cla-server/dbmodels"
 	"github.com/opensourceways/app-cla-server/util"
 )
 
 type CorporationManagerAuthentication struct {
-	User     string `json:"user" required:"true"`
-	Password string `json:"password" required:"true"`
+	User     string `json:"user"`
+	Password string `json:"password"`
 	dbmodels.OrgRepo
 }
 
 func (this CorporationManagerAuthentication) Validate() IModelError {
-	if _, err := golangsdk.BuildRequestBody(this, ""); err != nil {
-		return newModelError(ErrEmptyPayload, fmt.Errorf("necessary parameters error: %s", err.Error()))
+	if this.Platform == "" || this.OrgID == "" || this.Password == "" || this.User == "" {
+		return newModelError(ErrEmptyPayload, fmt.Errorf("necessary parameters is empty"))
 	}
 
 	return nil