Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version is not displayed #140

Closed
tormath1 opened this issue Jun 28, 2020 · 1 comment
Closed

version is not displayed #140

tormath1 opened this issue Jun 28, 2020 · 1 comment
Assignees
Labels
area:documentation Improvements or additions to documentation
Milestone

Comments

@tormath1
Copy link

Hey, while upgrading gotop version on Gentoo (Guru), I found this regression:

gotop version:

gotop -V, or if built from source, git rev-parse HEAD

$ git rev-parse HEAD
e59e91847b44d98aa5148ea184c9755dda302c98
$ ./gotop -V
gotop 0.0.0 (Hadean)
OS/Arch:

Linux: uname -or, OSX: sw_vers; Windows: systeminfo | findstr /B /C:"OS Name" /C:"OS Version"

Terminal emulator:

e.g. iTerm, kitty, xterm, PowerShell

Any relevant hardware info:

If the issue is clearly related to a specific piece of hardware, e.g., the network

tmux version:

tmux -V, if using tmux

Also please copy or attach ~/.local/state/gotop/errors.log if it exists and contains logs:

xxxserxxx added a commit that referenced this issue Jul 1, 2020
@xxxserxxx xxxserxxx self-assigned this Jul 1, 2020
@xxxserxxx xxxserxxx added the area:documentation Improvements or additions to documentation label Jul 1, 2020
@xxxserxxx xxxserxxx added this to the v4.0.2 milestone Jul 1, 2020
@xxxserxxx
Copy link
Owner

@tormath1 , this is as designed. Rather than hard-coding the version number, it's embedded at compile time. However, the README didn't explain how to set the version -- that's now addressed, and the Building section now includes those instructions.

Thanks for the report!

@xxxserxxx xxxserxxx modified the milestones: v4.0.2, v4.1.0 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants