Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature widget is not working ( not showing anything) !!! #16

Closed
xxxserxxx opened this issue Feb 15, 2020 · 33 comments
Closed

Temperature widget is not working ( not showing anything) !!! #16

xxxserxxx opened this issue Feb 15, 2020 · 33 comments
Assignees
Labels
bug Something isn't working needs:review To determine inclusion or wont-fix os:linux
Milestone

Comments

@xxxserxxx
Copy link
Owner

Required information:

  • gotop version (gotop -v): 2.0.0

  • The output of uname -a: Linux XXX-X542UN 4.18.0-14-generic exit (crash) immediately to shell if -b is passed #15~18.04.1-Ubuntu SMP Mon Jan 14 11:09:26 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

  • Terminal shell (e.g. zsh or bash): bash

  • Terminal emulator (e.g. iTerm or gnome terminal): gnome terminal

  • Any relevenat hardware info: CPU: Intel i5-7200U, GPU: Intel HD Graphics 620, GPU: NVIDIA GeForce MX150

  • tmux version if using tmux:

Also please copy or attach the following file if it exists and contains logs:

  • Linux: ~/.local/state/gotop/errors.log
  • OSX: ~/Library/Logs/gotop/errors.log

~/.local/state/gotop/errors.log is EMPTY !!
Installlation method: Prebuilt binaries

@xxxserxxx xxxserxxx added the bug Something isn't working label Feb 15, 2020
@xxxserxxx
Copy link
Owner Author

Similar to #101. Is this a laptop or desktop? And if a laptop, what model?

@xxxserxxx
Copy link
Owner Author

Also, can you run this and copy the output here:

package main

import (
    "fmt"

    "github.com/shirou/gopsutil/host"
)

func main() {
    temperatures, err := host.SensorsTemperatures()
    fmt.Println(temperatures)
    fmt.Println(err)
}

@xxxserxxx
Copy link
Owner Author

Similar to #101. Is this a laptop or desktop? And if a laptop, what model?

It's a laptop: ASUS Vivobook 15 X542UN

lsb_release -a
No LSB modules are available.
Distributor ID:	LinuxMint
Description:	Linux Mint 19.1 Tessa
Release:	19.1
Codename:	tessa

I forgot to mention that everything was working perfectly when I first installed gotop, but after a while for some reason the temperatures widget became empty, I also didn't mention that the Disk Usage widget also doesn't work, i mean its there (not empty) the "Used" and "Free" sections show correct information but the "R/s" and "W/s" are always 0B, when i installed it everything was working perfectly !!!

Of course, I updated the gotop folder to the latest release by using "git pull origin master", I tried to remove it, and reinstall again from the source, but the problem is still there.

Here is 2 screenshots, one shows that everything was working fine, the other one i just took and you can see the empty temperature widget

screenshot from 2018-11-18 17-55-19
screenshot from 2019-02-02 16-53-50

Also, can you run this and copy the output here:

package main

import (
    "fmt"

    "github.com/shirou/gopsutil/host"
)

func main() {
    temperatures, err := host.SensorsTemperatures()
    fmt.Println(temperatures)
    fmt.Println(err)
}

I tried but it gives me these errors:

package: cannot open distribution file
./test: line 3: syntax error near unexpected token `newline'
./test: line 3: `import (
```'

`package: can't open config file /home/bahaa/.mailagent
./test: line 3: syntax error near unexpected token `newline'
./test: line 3: `import ('`

@xxxserxxx
Copy link
Owner Author

Oh, you have to copy that file into main.go, and then run it with go run main.go. Let me know if you still get issues after that.

@xxxserxxx
Copy link
Owner Author

Oh, you have to copy that file into main.go, and then run it with go run main.go. Let me know if you still get issues after that.

main.go:17:2: cannot find package "github.com/ProtonMail/go-appdir" in any of: /usr/lib/go-1.10/src/github.com/ProtonMail/go-appdir (from $GOROOT) /home/bahaa/go/src/github.com/ProtonMail/go-appdir (from $GOPATH) main.go:18:2: cannot find package "github.com/cjbassi/gotop/colorschemes" in any of: /usr/lib/go-1.10/src/github.com/cjbassi/gotop/colorschemes (from $GOROOT) /home/bahaa/go/src/github.com/cjbassi/gotop/colorschemes (from $GOPATH) main.go:19:2: cannot find package "github.com/cjbassi/gotop/src/logging" in any of: /usr/lib/go-1.10/src/github.com/cjbassi/gotop/src/logging (from $GOROOT) /home/bahaa/go/src/github.com/cjbassi/gotop/src/logging (from $GOPATH) main.go:20:2: cannot find package "github.com/cjbassi/gotop/src/widgets" in any of: /usr/lib/go-1.10/src/github.com/cjbassi/gotop/src/widgets (from $GOROOT) /home/bahaa/go/src/github.com/cjbassi/gotop/src/widgets (from $GOPATH) main.go:21:2: cannot find package "github.com/docopt/docopt.go" in any of: /usr/lib/go-1.10/src/github.com/docopt/docopt.go (from $GOROOT) /home/bahaa/go/src/github.com/docopt/docopt.go (from $GOPATH) main.go:22:2: cannot find package "github.com/gizak/termui" in any of: /usr/lib/go-1.10/src/github.com/gizak/termui (from $GOROOT) /home/bahaa/go/src/github.com/gizak/termui (from $GOPATH)

@xxxserxxx
Copy link
Owner Author

Here try:

go get github.com/cjbassi/test
go run github.com/cjbassi/test

@xxxserxxx
Copy link
Owner Author

go run github.com/cjbassi/test

pay attention that my previous answer was edited

go run github.com/cjbassi/test go run: no go files listed

@xxxserxxx
Copy link
Owner Author

Do you have a working GOPATH set up? What's your Go version? If you have go 1.11 then you can probably just clone that repo and run go run main.go also. Or else navigate to your gopath and run the project directly.

@xxxserxxx
Copy link
Owner Author

Or use this binary:
test.zip

@xxxserxxx
Copy link
Owner Author

Do you have a working GOPATH set up? What's your Go version? If you have go 1.11 then you can probably just clone that repo and run go run main.go also. Or navigate to your gopath and run the project directly, idk.

First of all I'm sorry but it's my first time working with golang, so I'm kind of don't know what exactly I'm doing.

My go version:
go version go1.10.4 linux/amd64


Ok i did the following:

export GOPATH=$HOME/go
cd ~/go/src/github.com/cjbassi/test

There I found 'main.go' file

I ran:

go run main.go

I got the following output:

[{"sensorKey":"acpitz_crit","sensorTemperature":103} {"sensorKey":"acpitz_input","sensorTemperature":34} {"sensorKey":"coretemp_packageid0_crit","sensorTemperature":100} {"sensorKey":"coretemp_packageid0_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_packageid0_input","sensorTemperature":37} {"sensorKey":"coretemp_packageid0_max","sensorTemperature":100} {"sensorKey":"coretemp_core0_crit","sensorTemperature":100} {"sensorKey":"coretemp_core0_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_core0_input","sensorTemperature":33} {"sensorKey":"coretemp_core0_max","sensorTemperature":100} {"sensorKey":"coretemp_core1_crit","sensorTemperature":100} {"sensorKey":"coretemp_core1_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_core1_input","sensorTemperature":37} {"sensorKey":"coretemp_core1_max","sensorTemperature":100} {"sensorKey":"pch_skylake_input","sensorTemperature":30.5}] read /sys/class/hwmon/hwmon4/temp1_input: network is down

And I found this error in ~/.local.stat.gotop.errors.log

12:49:11 temp_other.go:16: failed to get sensors from gopsutil: read /sys/class/hwmon/hwmon4/temp1_input: network is down


I thought this might be helpful:

I also have gotop installed on Termux on my android tablet, the temperature widget is working there, and i got the following output after running the main.go file in the gotop directory after adding to it :

package main

import (
    "fmt"

    "github.com/shirou/gopsutil/host"
)

func main() {
    temperatures, err := host.SensorsTemperatures()
    fmt.Println(temperatures)
    fmt.Println(err)
}

The output:

go: finding github.com/shirou/w32 v0.0.0-20160930032740-bb4de0191aa4 go: finding github.com/pmezard/go-difflib v1.0.0 go: finding github.com/ProtonMail/go-appdir v0.0.0-20180220133335-7c788d1b45c6 go: finding github.com/mattn/go-runewidth v0.0.4 go: finding github.com/shirou/gopsutil v2.18.11+incompatible go: finding github.com/docopt/docopt.go v0.0.0-20180111231733-ee0de3bc6815 go: finding github.com/mitchellh/go-wordwrap v1.0.0 go: finding github.com/go-ole/go-ole v1.2.1 go: finding github.com/gizak/termui v0.0.0-20190124041613-958a28575d74 go: finding howett.net/plist v0.0.0-20181124034731-591f970eefbb go: finding github.com/stretchr/testify v1.2.2 go: finding github.com/DHowett/go-plist v0.0.0-20180729002649-fed556ad7290 go: finding github.com/davecgh/go-spew v1.1.1 go: finding github.com/distatus/battery v0.0.0-20170521010419-916919eb43bd go: finding github.com/StackExchange/wmi v0.0.0-20180116203802-5d049714c4a6 go: finding github.com/cjbassi/drawille-go v0.0.0-20180329221028-ad535d0f92cd go: finding github.com/nsf/termbox-go v0.0.0-20190104133558-0938b5187e61 go: finding github.com/kr/pretty v0.1.0 go: finding gopkg.in/yaml.v2 v2.2.1 go: finding github.com/mitchellh/go-wordwrap v0.0.0-20150314170334-ad45545899c7 go: finding github.com/jessevdk/go-flags v1.4.0 go: github.com/cjbassi/drawille-go@v0.0.0-20180329221028-ad535d0f92cd: unknown revision ad535d0f92cd go: finding github.com/nsf/termbox-go v0.0.0-20180613055208-5c94acc5e6eb go: finding github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6 go: finding golang.org/x/crypto v0.0.0-20190103213133-ff983b9c42bc go: finding github.com/google/pprof v0.0.0-20190109223431-e84dfd68c163 go: finding golang.org/x/sys v0.0.0-20190116161447-11f53e031339 go: finding github.com/mattn/go-runewidth v0.0.2 go: finding golang.org/x/arch v0.0.0-20181203225421-5a4828bb7045 go: finding gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 go: error loading module requirements

I also ran the following commands as you asked but this time on termux with working temperature widget:

go run github.com/cjbassi/test [{"sensorKey":"tsens_tz_sensor0_input","sensorTemperature":0.352} {"sensorKey":"tsens_tz_sensor9_input","sensorTemperature":0.419} {"sensorKey":"tsens_tz_sensor10_input","sensorTemperature":0.387} {"sensorKey":"tsens_tz_sensor11_input","sensorTemperature":0.39} {"sensorKey":"tsens_tz_sensor12_input","sensorTemperature":0.393} {"sensorKey":"tsens_tz_sensor13_input","sensorTemperature":0.358} {"sensorKey":"tsens_tz_sensor14_input","sensorTemperature":0.329} {"sensorKey":"tsens_tz_sensor15_input","sensorTemperature":0.345} {"sensorKey":"tsens_tz_sensor16_input","sensorTemperature":0.358} {"sensorKey":"tsens_tz_sensor17_input","sensorTemperature":0.355} {"sensorKey":"tsens_tz_sensor18_input","sensorTemperature":0.339} {"sensorKey":"tsens_tz_sensor1_input","sensorTemperature":0.381} {"sensorKey":"tsens_tz_sensor19_input","sensorTemperature":0.339} {"sensorKey":"tsens_tz_sensor20_input","sensorTemperature":0.342} {"sensorKey":"pm8994_tz_crit","sensorTemperature":145} {"sensorKey":"pm8994_tz_input","sensorTemperature":36.492} {"sensorKey":"pm8004_tz_crit","sensorTemperature":145} {"sensorKey":"pm8004_tz_input","sensorTemperature":37} {"sensorKey":"msm_therm_input","sensorTemperature":0.034} {"sensorKey":"emmc_therm_input","sensorTemperature":0.028} {"sensorKey":"pa_therm0_input","sensorTemperature":-0.04} {"sensorKey":"pa_therm1_input","sensorTemperature":0.028} {"sensorKey":"quiet_therm_input","sensorTemperature":-0.04} {"sensorKey":"xo_therm_buf_input","sensorTemperature":0.032} {"sensorKey":"tsens_tz_sensor2_input","sensorTemperature":0.358} {"sensorKey":"sm5705-fuelgauge_input","sensorTemperature":32} {"sensorKey":"DLMt_APC1_input","sensorTemperature":0} {"sensorKey":"LLM_cp00_input","sensorTemperature":0} {"sensorKey":"LLM_cp01_input","sensorTemperature":0} {"sensorKey":"LLM_cp10_input","sensorTemperature":0} {"sensorKey":"LLM_cp11_input","sensorTemperature":0} {"sensorKey":"LLM_m4m0_input","sensorTemperature":0} {"sensorKey":"LLM_l21-_input","sensorTemperature":0} {"sensorKey":"LLM_l20-_input","sensorTemperature":0} {"sensorKey":"tsens_tz_sensor3_input","sensorTemperature":0.374} {"sensorKey":"ac_input","sensorTemperature":29.3} {"sensorKey":"battery_input","sensorTemperature":28.4} {"sensorKey":"tsens_tz_sensor4_input","sensorTemperature":0.368} {"sensorKey":"tsens_tz_sensor5_input","sensorTemperature":0.365} {"sensorKey":"tsens_tz_sensor6_input","sensorTemperature":0.368} {"sensorKey":"tsens_tz_sensor7_input","sensorTemperature":0.381} {"sensorKey":"tsens_tz_sensor8_input","sensorTemperature":0.403}] <nil>

@xxxserxxx
Copy link
Owner Author

Thanks for all the info and I'm glad you got it working! And no worries about being new. I should've been more helpful actually. It's a little tricky to setup Go for the first time and I shouldn't expect that everyone has done that already.

So that actually clears a few things up for now. I'll check through this tomorrow and let you know what I come up with.

@xxxserxxx
Copy link
Owner Author

So this should be fixed now! Let me know if you get any more issues otherwise. And thanks for taking the time to setup Go and do all the testing.

@xxxserxxx
Copy link
Owner Author

Thanks for being responsive, and I'm glad to be part of this.

But unfortunately the problem is still there.

~/.locale/state/gotop/errors.log:

18:49:18 temp_other.go:16: failed to get sensors from gopsutil: read /sys/class/hwmon/hwmon4/temp1_input: network is down

go run main.go 
[{"sensorKey":"acpitz_crit","sensorTemperature":103} {"sensorKey":"acpitz_input","sensorTemperature":38} {"sensorKey":"coretemp_packageid0_crit","sensorTemperature":100} {"sensorKey":"coretemp_packageid0_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_packageid0_input","sensorTemperature":39} {"sensorKey":"coretemp_packageid0_max","sensorTemperature":100} {"sensorKey":"coretemp_core0_crit","sensorTemperature":100} {"sensorKey":"coretemp_core0_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_core0_input","sensorTemperature":37} {"sensorKey":"coretemp_core0_max","sensorTemperature":100} {"sensorKey":"coretemp_core1_crit","sensorTemperature":100} {"sensorKey":"coretemp_core1_critalarm","sensorTemperature":0} {"sensorKey":"coretemp_core1_input","sensorTemperature":39} {"sensorKey":"coretemp_core1_max","sensorTemperature":100} {"sensorKey":"pch_skylake_input","sensorTemperature":34.5}]
read /sys/class/hwmon/hwmon4/temp1_input: network is down

@xxxserxxx
Copy link
Owner Author

Did you try running gotop from the master branch? I haven't released a new version yet so that's your only option for now.

@xxxserxxx
Copy link
Owner Author

Yes, I did. still no temperatures !!

screenshot from 2019-02-05 13-27-35

@xxxserxxx
Copy link
Owner Author

So I noticed the error message you recently got is the same as before, but I changed that message when I fixed this. :D So maybe it was leftover? Or maybe gotop didn't update correctly. Can you tell me how you updated exactly? If you have your gopath set up then you should be able to do go get -u github.com/cjbassi/gotop and the updated gotop binary should be in ~/go/bin/gotop. Or maybe git clone the repo and try go run main.go.

@xxxserxxx
Copy link
Owner Author

go get -u github.com/cjbassi/gotop

works perfectly, thank you

Great job.

screenshot from 2019-02-05 21-42-02

@xxxserxxx
Copy link
Owner Author

Yay! Glad its working :D Thanks again being responsive and helping with this.

@xxxserxxx
Copy link
Owner Author

This did not work for me.

I installed go, and tried the go get -u github.com/cjbassi/gotop but still have no temperature charts

Running the go run github.com/cjbassi/test gived me this error:

package github.com/cjbassi/test: cannot find package "github.com/cjbassi/test" in any of:
        /usr/local/go/src/github.com/cjbassi/test (from $GOROOT)
        /home/chiya/work/src/github.com/cjbassi/test (from $GOPATH)

I'm guessing more people will experience this same issue, and are wondering if there is a proper step-by-step on how to fix this?

@xxxserxxx
Copy link
Owner Author

So I fixed this issue on gotop's end, but it turns out that gopsutil has an issue on its end within the SensorsTemperatures function here that is probably causing this issue for you still, I just forgot to reopen this.

Basically, SensorsTemperatures iterates the filesystem and early returns on the first error it encounters instead of trying to continue onto the next file. So if an error is encountered in the first file, no temperatures are read/shown. Instead, it needs to return an array of errors and append any errors it finds and return that at the end.

I did some work on this here but I think I got stuck trying to test it and I've been pretty busy.

@zelch
Copy link

zelch commented Mar 6, 2020

So, I have an alternate fix for this, and a... Mildly expansion and abuse of the temperature widget tied into it.

I'll make a pull request shortly.

The short version is that both the gotop and gopsutils have some issues and limitations.

First, gopsutils doesn't handle errors perfectly, though this seems to be improving.

Second, if gopsutils returns any errors, gotop ignores all of the data, even when gopsutils also returns data. This isn't optimal.

Third, and this is more in the realm of 'enhancements', gopsutils only deals with temperature data, and so gotop can't handle other useful data such as fan speeds even if it wanted to.

The fix to item 1 seems to be coming along, or to possibly already be done. The fix for item 2 is fairly straight forward, and if my answer to 3 isn't acceptable, I'd be happy to do that instead. The fix for 3 though is to just stop using gopsutils for sensor data.

Fixing 3 isn't horribly difficult once we switch to lmsensors, but it does mean that the entire 'temp' widget either shouldn't be doing everything, or should be renamed to sensors. I'm definitely open to requests on how to handle that.

@xxxserxxx
Copy link
Owner Author

@zelch thanks for looking into this!

Another thing I've been playing with is alternative libraries such as github.com/elastic/go-sysinfo. There are a few of them to choose from. I've done some work with other libraries, mainly focused on procs; the considerations are the same for other widgets:

  1. We still need support for multiple OSes (OSX, Windows, BSD, and Linux). We can provide custom interfaces per OS, but fixes should be as broad as possible.
  2. Many libraries have issues with accessing devices depending on security settings. On Linux, the go-sysinfo gathers process information from /proc, and process info is restricted to non-root users. This means that go-sysinfo can't gather information about all processes. This may, or may not, affect other widgets such as temp, and we need to be careful about it. The current Linux procs widget pulls from forking the ps command, which has no such restriction.
  3. Correct (bug free) behavior is a top priority, but a close second is performance. gopsutils has performance issues (3x CPU use) when used to pull process information vs. the current forking ps code.

You're right: the new abstracted device code handles errors better, but it could be better for temperatures. The gopsutils API is poorly documented, and it isn't clear (except by reading the source code) that it returns partial results. That's an easy fix -- as you may have seen -- because the API is already positioned to handle multiple errors and partial results.

Finally, WRT fan speeds: can you create a separate feature request for that? Design-wise, it should be a new device, and then we'll figure out how to display the information. Since fans are common, this can go into core gotop rather than as a plugin. Whatever the solution is, we need a path to support all supported OSes.

@zelch
Copy link

zelch commented Mar 8, 2020

The library I have my current implementation with also pulls from /sys via the hwmon interface, the same as gopsutils, so I would expect it to have similar performance implications, though that can certainly be tested. But it is also a linux specific library.

On the fan speeds, I can definitely make a separate feature request, but I'm not actually sure that this is the right thing to do.

Or perhaps to say it slightly differently, I'm fairly sure that we would want to replace the current temperature handling with a more generic sensor framework, one that can possibly handling feeding in not just different kinds of sensors, but also from multiple different sources, and then feed back out to widgets that want the right kind of data.

Alternatively, we could just go for a generic sensor widget, which is far easier but is probably not the right actual answer.

@xxxserxxx
Copy link
Owner Author

@zelch I believe this is already in place. CPU, Temp, and Mem are already broken out into devices; this decouples them from widgets. To add new devices, we add code to devices/ and they self-register with the appropriate widget. The widgets display data from registered devices. Not all devices are decoupled yet, but they're getting there.

If we're adding new features, it should be separated from this bug, though.

Would you mind forking this repository, adding code to test your library, running the tests, and sending a pull request? You can run the whole suite, but to run just the temp benchmarks, use

go test -benchtime=5s -bench=BenchmarkTemp\*  .

or something similar.

Your comment about abstracting out the sensors got me thinking design, and it got long, so I started a wiki page. Are you able to comment? If not, let me know and I'll figure out how to give you permission to edit wiki pages.

@xxxserxxx
Copy link
Owner Author

The conversation turned to using different libraries, and strayed from the original bug. In the meantime, changes have been pushed to abstract out devices, and work's been done to collect errors and render available data. In the meantime, gopsutils has gone through several version revisions.

Can anyone confirm if they still see this issue?

@xxxserxxx xxxserxxx added the needs:review To determine inclusion or wont-fix label Jul 24, 2020
@xxxserxxx xxxserxxx removed this from the v4.0.2 milestone Jul 24, 2020
@prurigro
Copy link

prurigro commented Jan 1, 2021

I'm still getting this issue on an xps 7390 running archlinux. My desktop shows temperatures correctly.

@rubiojr
Copy link

rubiojr commented Feb 1, 2021

✋ same. Thinkpad x390 running Ubuntu 20.04. Tried both released binaries and current master.

output from the snipped added to #16 (comment):

{"sensorKey":"acpitz_crit","sensorTemperature":128}
{"sensorKey":"acpitz_input","sensorTemperature":49}
{"sensorKey":"nvme_composite_alarm","sensorTemperature":0}
{"sensorKey":"nvme_composite_crit","sensorTemperature":84.85}
{"sensorKey":"nvme_composite_input","sensorTemperature":40.85}
{"sensorKey":"nvme_composite_max","sensorTemperature":84.85}
{"sensorKey":"nvme_composite_min","sensorTemperature":-273.15}
{"sensorKey":"nvme_sensor1_input","sensorTemperature":40.85}
{"sensorKey":"nvme_sensor1_max","sensorTemperature":65261.85}
{"sensorKey":"nvme_sensor1_min","sensorTemperature":-273.15}
{"sensorKey":"nvme_sensor2_input","sensorTemperature":40.85}
{"sensorKey":"nvme_sensor2_max","sensorTemperature":65261.85}
{"sensorKey":"nvme_sensor2_min","sensorTemperature":-273.15}
{"sensorKey":"pch_cannonlake_input","sensorTemperature":50}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":66}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":49}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":42}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"thinkpad_input","sensorTemperature":0}
{"sensorKey":"coretemp_packageid0_crit","sensorTemperature":100}
{"sensorKey":"coretemp_packageid0_critalarm","sensorTemperature":0}
{"sensorKey":"coretemp_packageid0_input","sensorTemperature":48}
{"sensorKey":"coretemp_packageid0_max","sensorTemperature":100}
{"sensorKey":"coretemp_core0_crit","sensorTemperature":100}
{"sensorKey":"coretemp_core0_critalarm","sensorTemperature":0}
{"sensorKey":"coretemp_core0_input","sensorTemperature":47}
{"sensorKey":"coretemp_core0_max","sensorTemperature":100}
{"sensorKey":"coretemp_core1_crit","sensorTemperature":100}
{"sensorKey":"coretemp_core1_critalarm","sensorTemperature":0}
{"sensorKey":"coretemp_core1_input","sensorTemperature":48}
{"sensorKey":"coretemp_core1_max","sensorTemperature":100}
{"sensorKey":"coretemp_core2_crit","sensorTemperature":100}
{"sensorKey":"coretemp_core2_critalarm","sensorTemperature":0}
{"sensorKey":"coretemp_core2_input","sensorTemperature":49}
{"sensorKey":"coretemp_core2_max","sensorTemperature":100}
{"sensorKey":"coretemp_core3_crit","sensorTemperature":100}
{"sensorKey":"coretemp_core3_critalarm","sensorTemperature":0}
{"sensorKey":"coretemp_core3_input","sensorTemperature":48}
{"sensorKey":"coretemp_core3_max","sensorTemperature":100}
{"sensorKey":"iwlwifi_1_input","sensorTemperature":42}
Number of warnings: 2

@xxxserxxx
Copy link
Owner Author

I'm still getting this issue on an xps 7390 running archlinux. My desktop shows temperatures correctly.

@prurigro, @rubiojr -- would you please let me know:

  1. The version of gotop (gotop -v)
  2. Information about your OS (uname -a)
  3. How you installed gotop

@prurigro
Copy link

prurigro commented Feb 4, 2021

Hey, thanks for the response, sure!

  1. gotop v4.1.1 (Hadean)
  2. Linux xps 5.10.12-arch1-1 #1 SMP PREEMPT Sun, 31 Jan 2021 00:41:06 +0000 x86_64 GNU/Linux
  3. I installed it using this package https://aur.archlinux.org/packages/gotop/ (build script: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gotop)

Interestingly, after I upgraded from 4.1.0 to 4.1.1 the temperature widget became populated with the correct devices but all the values are 0°C so I'm not sure if this is exactly the same issue -- I've since retired the desktop the temperature widget was working on so I can't check to see if the 0 degrees problem appeared there, but it's also present on the new desktop I replaced it with.

The gotop temp widget on my new desktop:
gotop-temperatures

The s-tui temp widget on my new desktop:
s-tui-temperatures

Let me know if you need anything more.

@rubiojr
Copy link

rubiojr commented Feb 14, 2021

@xxxserxxx:

  % gotop -v                                                                                    !10094
2021/02/14 15:29:56 gopsutil reports Number of warnings: 1
2021/02/14 15:29:56 gopsutil reports Number of warnings: 1
gotop v4.1.1 (20210203T222450)
  % uname -a                                                                                                                                                                                            !10096
Linux mostruo 5.8.0-43-generic #49~20.04.1-Ubuntu SMP Fri Feb 5 09:57:56 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Downloaded from releases, also tried current master via go get.

@xxxserxxx xxxserxxx self-assigned this Mar 30, 2021
@xxxserxxx xxxserxxx added this to the v4.1.2 milestone Mar 30, 2021
@dkwo
Copy link

dkwo commented May 12, 2021

Same issue here, on thinkpad.

$ gotop -v
2021/05/12 13:42:16 gopsutil reports Number of warnings: 1
2021/05/12 13:42:16 gopsutil reports Number of warnings: 1
gotop v4.1.1 (Hadean)
$ xuname
Void 5.11.18_1 x86_64-musl GenuineIntel uptodate hold rrnFFF

installed from the package manager.

All is at 0 deg C.

@xxxserxxx xxxserxxx modified the milestones: v4.1.2, v4.1.3 Jul 20, 2021
@xxxserxxx xxxserxxx modified the milestones: v4.1.3, v4.1.4 Feb 14, 2022
@kzdixon
Copy link

kzdixon commented Feb 21, 2022

Have two systems, temp works on one but not the other.

Working (Intel i7-3770):

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +43.0°C  (high = +85.0°C, crit = +105.0°C)
Core 0:        +40.0°C  (high = +85.0°C, crit = +105.0°C)
Core 1:        +43.0°C  (high = +85.0°C, crit = +105.0°C)
Core 2:        +38.0°C  (high = +85.0°C, crit = +105.0°C)
Core 3:        +33.0°C  (high = +85.0°C, crit = +105.0°C)

gotop v4.1.3 (Hadean)

Linux server 5.15.21-hardened1-3-hardened #1 SMP PREEMPT Mon, 14 Feb 2022 23:58:27 +0000 x86_64 GNU/Linux

Not working (Ryzen 5800X):

hidpp_battery_1-hid-3-1a
Adapter: HID adapter
in0:           4.03 V

nvme-pci-0100
Adapter: PCI adapter
Composite:    +24.9°C  (low  = -273.1°C, high = +80.8°C)
                       (crit = +80.8°C)
Sensor 1:     +24.9°C  (low  = -273.1°C, high = +65261.8°C)
Sensor 2:     +52.9°C  (low  = -273.1°C, high = +65261.8°C)

acpitz-acpi-0
Adapter: ACPI interface
temp1:        +16.8°C  (crit = +20.8°C)

iwlwifi_1-virtual-0
Adapter: Virtual device
temp1:            N/A

k10temp-pci-00c3
Adapter: PCI adapter
Tctl:         +43.4°C
Tccd1:        +37.2°C

nvme-pci-0500
Adapter: PCI adapter
Composite:    +25.9°C  (low  = -273.1°C, high = +80.8°C)
                       (crit = +80.8°C)
Sensor 1:     +25.9°C  (low  = -273.1°C, high = +65261.8°C)
Sensor 2:     +55.9°C  (low  = -273.1°C, high = +65261.8°C)

nvme-pci-0400
Adapter: PCI adapter
Composite:    +26.9°C  (low  = -273.1°C, high = +80.8°C)
                       (crit = +80.8°C)
Sensor 1:     +26.9°C  (low  = -273.1°C, high = +65261.8°C)
Sensor 2:     +51.9°C  (low  = -273.1°C, high = +65261.8°C)

2022/02/21 00:19:05 gopsutil reports Number of warnings: 1
2022/02/21 00:19:05 gopsutil reports Number of warnings: 1
gotop v4.1.3 (Hadean)

Linux desktop 5.16.10-zen1-1-zen #1 ZEN SMP PREEMPT Wed, 16 Feb 2022 19:35:21 +0000 x86_64 GNU/Linux

@xxxserxxx
Copy link
Owner Author

It's certainly possible that #219 addresses this for most people, so I'm going to close this and we'll re-open it if people are still experiencing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:review To determine inclusion or wont-fix os:linux
Projects
None yet
Development

No branches or pull requests

6 participants