Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation #165

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Add French translation #165

merged 3 commits into from
Feb 11, 2021

Conversation

bbjubjub2494
Copy link

@bbjubjub2494 bbjubjub2494 commented Feb 8, 2021

Per #120.

I am a native speaker and completed compulsory education entirely in French.

I am shooting for standard French, which should be intelligible to French speakers worldwide.

Don't merge yet, I want to check all translations in context.

@bbjubjub2494 bbjubjub2494 changed the title WIP: Add French translation Add French translation Feb 10, 2021
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review February 10, 2021 10:20
@xxxserxxx xxxserxxx self-assigned this Feb 10, 2021
@xxxserxxx xxxserxxx added the area:translation I18n language translation label Feb 10, 2021
@xxxserxxx xxxserxxx added this to the v4.1.2 milestone Feb 10, 2021
nohostname="22| ne peut obtenir le nom d'hôte: {0}"

[layout.error]
widget="23| Nom de widget invalide {0}. Must be one of {1}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the message got missed; "Must be one of" => "Doit être l'un des"?

Copy link
Owner

@xxxserxxx xxxserxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this translation! One message got missed, but the rest looks good to my very rusty French!

Copy link
Owner

@xxxserxxx xxxserxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go generate changed smc.go unnecessarily, and updated the timestamp. Could you please revert this change? It is not relevant to the PR. Thank you.

@xxxserxxx xxxserxxx merged commit aad28e9 into xxxserxxx:master Feb 11, 2021
@xxxserxxx
Copy link
Owner

This looks good; thanks for the translation, and for making the requested changes. It'll go out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:translation I18n language translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants