Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement brand updates #43

Merged
merged 7 commits into from
Sep 6, 2023
Merged

feat: implement brand updates #43

merged 7 commits into from
Sep 6, 2023

Conversation

steven-klein
Copy link
Collaborator

@steven-klein steven-klein commented Aug 31, 2023

What this does

This update implements the minimum changes expected to stay consistent with incoming brand guidelines:

  • adds new brand color palettes and typography
  • applies updated colors to app shells, buttons, form inputs, and some select components

Notes

  • The use of font-display is entirely optional and should be used sparingly. It works well for large headings in CTA banners and should typically be set alongside font-extrabold with a line-height that is the same or very close to the font size.
  • The default color weight of xy-green changes from a 600 to a 300 and does not meet accessibility requirements as text. It should primarily be used as a background color with text-xy-black or a similar 800+ color weight. Some exceptions will apply to icons or other presentation role interface items where legibility is less of a concern.
  • The spinning indicator has a heavy branding baked into it. It has been prepped to deploy alongside logo changes at a later date. It will for a short period maintain old brand colors and marks.
  • Tailwindcss@3.3 now ships with the line-clamp utility baked in, and the additional module is no longer required

To Preview In An Existing App

npm install @xy-planning-network/trees@dev
npm install --save-dev tailwindcss@latest

Breaking Changes

  • xy-btn-green has been removed
  • xy-navy has been removed (portal is likely to continue to stub this into its config to ease the refactor)
  • xy-dawn has been removed
  • xy-lime has been removed

Major Considerations

  • xy-green is a very different default color, best to review existing uses

@steven-klein
Copy link
Collaborator Author

@profsmallpine There's a @dev version up if you want to see how this feels in Archive. I left details in the PR note about setting the neutral palette in the app config as well. I could use a second opinion on whether not we do a full replacement and tweak as needed, or leave it intact and implement neutral via search and replace or as we see fit here and there.

Ergonomically, it's quite a bit nicer to type bg-gray, text-gray etc. Though autocompletion does most of the work anyway on text-neutral.

@steven-klein steven-klein changed the title implement brand updates feat: implement brand updates Sep 6, 2023
@steven-klein steven-klein marked this pull request as ready for review September 6, 2023 20:37
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only component that presented any kind of logistical challenge, since it contains a version of the XY logo. I applied the new brand colors to the icon, and left a potentially suitable replacement (the new logo mark) in there to be bumped at a later date. I don't feel particularly compelled to cut another release to coincide with the logo reveal - I think we'd just live with the XY until the next Trees bump comes around.

@steven-klein steven-klein merged commit bc7ee21 into main Sep 6, 2023
1 check passed
@steven-klein steven-klein deleted the spk/brand-integration branch August 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants