-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement brand updates #43
Conversation
@profsmallpine There's a @dev version up if you want to see how this feels in Archive. I left details in the PR note about setting the neutral palette in the app config as well. I could use a second opinion on whether not we do a full replacement and tweak as needed, or leave it intact and implement neutral via search and replace or as we see fit here and there. Ergonomically, it's quite a bit nicer to type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only component that presented any kind of logistical challenge, since it contains a version of the XY logo. I applied the new brand colors to the icon, and left a potentially suitable replacement (the new logo mark) in there to be bumped at a later date. I don't feel particularly compelled to cut another release to coincide with the logo reveal - I think we'd just live with the XY until the next Trees bump comes around.
What this does
This update implements the minimum changes expected to stay consistent with incoming brand guidelines:
Notes
font-display
is entirely optional and should be used sparingly. It works well for large headings in CTA banners and should typically be set alongsidefont-extrabold
with a line-height that is the same or very close to the font size.xy-green
changes from a 600 to a 300 and does not meet accessibility requirements as text. It should primarily be used as a background color withtext-xy-black
or a similar 800+ color weight. Some exceptions will apply to icons or other presentation role interface items where legibility is less of a concern.To Preview In An Existing App
npm install @xy-planning-network/trees@dev
npm install --save-dev tailwindcss@latest
Breaking Changes
xy-btn-green
has been removedxy-navy
has been removed (portal is likely to continue to stub this into its config to ease the refactor)xy-dawn
has been removedxy-lime
has been removedMajor Considerations
xy-green
is a very different default color, best to review existing uses