Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with code begins #37

Closed
wants to merge 1 commit into from
Closed

Fix problems with code begins #37

wants to merge 1 commit into from

Conversation

miroslavKovacPantheon
Copy link
Contributor

if code begins is not because of the
module but because of some other code,
it needs to be ignored

Signed-off-by: miroslav.kovac miroslav.kovac@pantheon.tech

@miroslavKovacPantheon
Fix problems with code begins
3bd35c6 
if code begins is not because of the
module but because of some other code,
it needs to be ignored

Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
einarnn
einarnn reviewed Mar 22, 2020
View reviewed changes
Copy link
Contributor

@einarnn einarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the changes in:

#36

They overlap with your proposed change.

@levkowetz
Copy link
Contributor

The code in PR #36 covers this case, too; but this PR does not handle the issue that #36 was created to fix (#35)

@einarnn
Copy link
Contributor

einarnn commented Mar 25, 2020

Taking @levkowetz PR instead.

@einarnn einarnn closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarnn einarnn einarnn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miroslavKovacPantheon @levkowetz @einarnn